Update flex volume plugin dir to match new RKE2 default; make it a Value
so that it can be changed by users to match the kubelet setting if
necessary.
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
This reverts commit 7b92af17fd.
Context:
The purpose behind introducing the previous change was to run a `make validate`, which checks if the `make prepare`, `make charts`, and `make sync` workflows worked as expected against the fork we plan to migrate to. This worked, as seen below:
```bash
arvindiyengar: ~/Rancher/rke2-charts/src/github.com/rancher/rke2-charts
$ make validate
./bin/charts-build-scripts validate
INFO[0000] Validating against released charts in migrate-live
... (omitted for brevity) ...
INFO[0002] Successfully validated against migrate-live!
```
Why do we need to bump all the packageVersions?
The new charts-build-scripts treat Chart.yaml and requirements.yaml as "managed files", which means that the scripts themselves can make changes to those files.
When the scripts touch those files (e.g. to add a new dependency based on the contents of generated-changes/dependencies or to patch a rcVersion or packageVersion to the chart), dumping back out the YAML results in slight changes due to the unmarshalling process, such as the re-ordering of annotations.
Since these minor changes comprise a change introduced by Rancher and the scripts refuse changes that modify already released packages, the simple fix for this is just to universally bump the packageVersion as part of the migration process.
As part of creating this PR, I generated these minor changes in https://github.com/aiyengar2/charts-diff/tree/rke2-charts/diff so that we can sign off that these are indeed inconsequential to the migration. For context, the process used to generate these files was:
- Pull in the current branch. Run make charts with the old scripts
- Pull in the migration branch. Run make charts with the new scripts
- Dump the diff between them in a patch file
Signed-off-by: Arvind Iyengar <arvind.iyengar@rancher.com>
```bash
arvindiyengar: ~/Rancher/rke2-charts/src/github.com/rancher/rke2-charts
$ curl -s https://raw.githubusercontent.com/aiyengar2/charts-build-scripts/add_init_steps/init.sh > /dev/null | sh
Pulling in charts-build-scripts version v0.0.4
charts-build-scripts version v0.0.4 (567c991)
INFO[0000] Pulling rancher/charts-build-scripts[path=templates] from upstream into templates299650162
INFO[0002] Successfully pulled new updated docs into working directory.
Pulled in basic template for source into configuration.yaml and constructed charts directory
Next Steps:
1. Modify the configuration.yaml with your expected setup and re-run make docs to automatically update the repository.
2. Modify .github/workflows/pull-request.md and .github/workflows/push.md to set up automatic pushes to another branch.
```
Signed-off-by: Arvind Iyengar <arvind.iyengar@rancher.com>
Brad Davidson
Jacob Blain Christen
Arvind Iyengar
Erik Wilson
Brian Downs
Chris Kim
Chris Kim