Fix falcon-sensor patch and clean up overlay

packages/falcon-sensor/generated-changes/overlay/app-readme.md

@@ -1,9 +0,0 @@
-# CrowdStrike Falcon
-
-[CrowdStrike](https://www.crowdstrike.com/) [Container Security](https://www.crowdstrike.com/cloud-security-products/falcon-cloud-workload-protection/)
-comes complete with vulnerability management, continuous
-threat detection and response, and runtime protection, combined with compliance
-enforcement and automated continuous integration/continuous delivery (CI/CD) pipeline security, enabling
-DevOps teams to stay secure while building in the cloud.
-
-For more information, please visit [https://www.crowdstrike.com/cloud-security-products/falcon-cloud-workload-protection/](https://www.crowdstrike.com/cloud-security-products/falcon-cloud-workload-protection/)

packages/falcon-sensor/generated-changes/overlay/questions.yaml

@@ -1,97 +0,0 @@
-questions:
-  - variable: node.image.repository
-    description: "URL of container image repository holding containerized Falcon sensor. Defaults to 'falcon-node-sensor'."
-    required: true
-    type: string
-    default: falcon-node-sensor
-    label: Container Image Repository
-    group: "Node Container Images"
-
-  - variable: node.image.tag
-    description: "Container registry image tag. Defaults to 'latest'."
-    required: true
-    type: string
-    default: "latest"
-    label: Container Image Tag
-    group: "Node Container Images"
-      
-  - variable: falcon.cid
-    description: "Passed to falconctl as \"--cid=\"{uuid string}\"\""
-    required: true
-    type: string
-    label: CrowdStrike Customer ID (CID)
-    group: "Falcon Sensor Node Settings"
-
-  - variable: falcon.apd
-    description: "App Proxy Disable. Passed to falconctl as \"--apt=true\" or \"--apt=false\"."
-    required: false
-    type: boolean
-    default: false
-    label: Disable using a proxy
-    group: "Falcon Sensor Node Settings"
-
-  - variable: falcon.aph
-    description: "App Proxy Hostname (APH). Uncommon in container-based deployments. Passed to falconctl as \"--aph <app proxy host name>\""
-    required: false
-    type: string
-    label: Configure Proxy Host
-    group: "Falcon Sensor Node Settings"
-
-  - variable: falcon.app
-    description: "App Proxy Port (APP). Uncommon in container-based deployments. Passed to falconctl as \"--app=<app proxy port>\""
-    required: false
-    type: string
-    label: Configure Proxy Port
-    group: "Falcon Sensor Node Settings"
-
-  - variable: falcon.trace
-    description: "Options are [none|err|warn|info|debug]. Passed to falconctl as \"--trace=[none|err|warn|info|debug]\""
-    required: false
-    type: string
-    label: Set logging trace level
-    default: "none"
-    group: "Falcon Sensor Node Settings"
-
-  - variable: falcon.feature
-    description: "Options to pass to the \"--feature\" flag. Options are [none,[enableLog[,disableLogBuffer[,disableOsfm[,emulateUpdate]]]]]"
-    required: false
-    type: string
-    label: Enable or disable certain sensor features
-    group: "Falcon Sensor Node Settings"
-
-  - variable: falcon.update
-    description: "SIGHUP the sensor for immediate trace/feature update."
-    required: false
-    type: boolean
-    default: false
-    label: Update sensor immediately
-    group: "Falcon Sensor Node Settings"
-
-  - variable: falcon.message_log
-    description: "Enable message log (true/false)"
-    required: false
-    type: boolean
-    default: false
-    label: Enable logging
-    group: "Falcon Sensor Node Settings"
-
-  - variable: falcon.billing
-    description: "Utilize default or metered billing. Should only be configured when needing to switch between the two. Options are: [default|metered]"
-    required: false
-    type: string
-    label: Configure Billing
-    group: "Falcon Sensor Node Settings"
-
-  - variable: falcon.tags
-    description: "Comma separated list of tags for sensor grouping. Allowed characters: all alphanumerics, '/', '-', '_', and ','."
-    required: false
-    type: string
-    label: Configure tags for sensor grouping
-    group: "Falcon Sensor Node Settings"
-      
-  - variable: falcon.provisioning_token
-    description: "Used to protect the CID. Provisioning token value."
-    required: false
-    type: string
-    label: Set a provisioning installation token
-    group: "Falcon Sensor Node Settings"

packages/falcon-sensor/generated-changes/patch/Chart.yaml.patch

@@ -1,6 +1,5 @@
-diff -x '*.tgz' -x '*.lock' -uNr packages/falcon-sensor/charts-original/Chart.yaml packages/falcon-sensor/charts/Chart.yaml
+--- charts-original/Chart.yaml
---- packages/falcon-sensor/charts-original/Chart.yaml
++++ charts/Chart.yaml
-+++ packages/falcon-sensor/charts/Chart.yaml
 @@ -20,3 +20,7 @@
  - https://github.com/CrowdStrike/falcon-helm
  type: application

packages/falcon-sensor/generated-changes/patch/questions.yaml.patch

@@ -0,0 +1,103 @@
+--- charts-original/questions.yaml
++++ charts/questions.yaml
+@@ -16,39 +16,39 @@
+     group: "Node Container Images"
+       
+   - variable: falcon.cid
+-    description: "CrowdStrike Customer ID (CID). Passed to falconctl as \"--cid=\"{uuid string}\"\""
++    description: "Passed to falconctl as \"--cid=\"{uuid string}\"\""
+     required: true
+     type: string
+-    label: --cid
++    label: CrowdStrike Customer ID (CID)
+     group: "Falcon Sensor Node Settings"
+ 
+   - variable: falcon.apd
+-    description: "Description goes here. Passed to falconctl as \"--apt=true\" or \"--apt=false\"."
++    description: "App Proxy Disable. Passed to falconctl as \"--apt=true\" or \"--apt=false\"."
+     required: false
+     type: boolean
+     default: false
+-    label: --apt
++    label: Disable using a proxy
+     group: "Falcon Sensor Node Settings"
+ 
+   - variable: falcon.aph
+     description: "App Proxy Hostname (APH). Uncommon in container-based deployments. Passed to falconctl as \"--aph <app proxy host name>\""
+     required: false
+     type: string
+-    label: --aph
++    label: Configure Proxy Host
+     group: "Falcon Sensor Node Settings"
+ 
+   - variable: falcon.app
+     description: "App Proxy Port (APP). Uncommon in container-based deployments. Passed to falconctl as \"--app=<app proxy port>\""
+     required: false
+     type: string
+-    label: --app
++    label: Configure Proxy Port
+     group: "Falcon Sensor Node Settings"
+ 
+   - variable: falcon.trace
+-    description: "Set trace level. Options are [none|err|warn|info|debug]. Passed to falconctl as \"--trace=[none|err|warn|info|debug]\""
++    description: "Options are [none|err|warn|info|debug]. Passed to falconctl as \"--trace=[none|err|warn|info|debug]\""
+     required: false
+     type: string
+-    label: --trace
++    label: Set logging trace level
+     default: "none"
+     group: "Falcon Sensor Node Settings"
+ 
+@@ -56,7 +56,7 @@
+     description: "Options to pass to the \"--feature\" flag. Options are [none,[enableLog[,disableLogBuffer[,disableOsfm[,emulateUpdate]]]]]"
+     required: false
+     type: string
+-    label: --feature
++    label: Enable or disable certain sensor features
+     group: "Falcon Sensor Node Settings"
+ 
+   - variable: falcon.update
+@@ -64,7 +64,7 @@
+     required: false
+     type: boolean
+     default: false
+-    label: --update
++    label: Update sensor immediately
+     group: "Falcon Sensor Node Settings"
+ 
+   - variable: falcon.message_log
+@@ -72,27 +72,26 @@
+     required: false
+     type: boolean
+     default: false
+-    label: --message-log
++    label: Enable logging
+     group: "Falcon Sensor Node Settings"
+ 
+   - variable: falcon.billing
+-    description: "Utilize default or metered billing."
++    description: "Utilize default or metered billing. Should only be configured when needing to switch between the two. Options are: [default|metered]"
+     required: false
+-    type: boolean
+-    default: true
+-    label: --billing
++    type: string
++    label: Configure Billing
+     group: "Falcon Sensor Node Settings"
+ 
+   - variable: falcon.tags
+     description: "Comma separated list of tags for sensor grouping. Allowed characters: all alphanumerics, '/', '-', '_', and ','."
+     required: false
+     type: string
+-    label: --tags
++    label: Configure tags for sensor grouping
+     group: "Falcon Sensor Node Settings"
+       
+   - variable: falcon.provisioning_token
+-    description: "Provisioning token value."
++    description: "Used to protect the CID. Provisioning token value."
+     required: false
+     type: string
+-    label: --provisioning-token
++    label: Set a provisioning installation token
+     group: "Falcon Sensor Node Settings"